fix: restore macro_call_data on inline macro parse errors#9863
Closed
s0mnathh wants to merge 1 commit intostarkware-libs:mainfrom
Closed
fix: restore macro_call_data on inline macro parse errors#9863s0mnathh wants to merge 1 commit intostarkware-libs:mainfrom
s0mnathh wants to merge 1 commit intostarkware-libs:mainfrom
Conversation
|
This change is |
orizi
requested changes
Apr 23, 2026
Collaborator
orizi
left a comment
orizi
left a comment
There was a problem hiding this comment.
@orizi made 1 comment.
Reviewable status: 0 of 1 files reviewed, 1 unresolved discussion (waiting on s0mnathh).
a discussion (no related file):
made unnecessary by #9868
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Ensure inline macro semantic paths always restore resolver macro_call_data, preventing context leakage on parser-error early returns.